Merge origin/main: reconcile ConfigWindow consolidation with Debug window + protocol updates

origin/main (23 commits) added a Debug window/log system on top of the old
separate Devices/Channels/Plot windows, plus protocol fixes (cml, mark10,
modbus_rtu, scpi) and device/profile changes. Local main (3 commits)
replaced the separate windows with a unified ConfigWindow + dock panel.

Kept local's ConfigWindow/dock architecture and ported the Debug window
onto it: new toolbar button + _open_debug(), gated by developer_mode same
as origin's version. Deduped the two independent "developer mode" toggles
that had collided in SettingsWindow (origin's General-tab checkbox gating
Debug window + device sim-mode visibility, local's Advanced-tab checkbox
setting verbose logging) into one General-tab checkbox that does both.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

1 files changed, 11 insertions, 7 deletions

diff --git a/api_layers/protocols/modbus_rtu.py b/api_layers/protocols/modbus_rtu.py
index 9d371b1..33f6877 100644
--- a/api_layers/protocols/modbus_rtu.py
+++ b/api_layers/protocols/modbus_rtu.py
@@ -91,10 +91,11 @@ class ModbusRTULayer(BaseProtocol):
 
     def _read_registers(self, fc: int, start: int, count: int) -> List[int]:
         req  = _frame(struct.pack(">BBHH", self.slave_addr, fc, start, count))
-        self._ser.write(req)
-        time.sleep(0.005)
-        n_bytes = 5 + 2 * count
-        resp = self._ser.read(n_bytes)
+        with self._io_lock:
+            self._ser.write(req)
+            time.sleep(0.005)
+            n_bytes = 5 + 2 * count
+            resp = self._ser.read(n_bytes)
         if len(resp) < n_bytes:
             raise IOError(f"Short response {len(resp)}/{n_bytes} bytes")
         crc_recv = struct.unpack("<H", resp[-2:])[0]
@@ -142,15 +143,18 @@ class ModbusRTULayer(BaseProtocol):
 
     def _write_register(self, register: int, value: int) -> bool:
         req  = _frame(struct.pack(">BBHH", self.slave_addr, 0x06, register, value & 0xFFFF))
-        self._ser.write(req)
-        time.sleep(0.005)
-        resp = self._ser.read(8)
+        with self._io_lock:
+            self._ser.write(req)
+            time.sleep(0.005)
+            resp = self._ser.read(8)
         return len(resp) == 8
 
     def write(self, channel_id: str, value) -> bool:
         ch = next((c for c in self.channels if c.channel_id == channel_id), None)
         if ch is None:
             return False
+        if self.simulate:
+            return True
         try:
             int_val = round((float(value) - ch.offset) / ch.scale)
             return self._write_register(ch.register, int_val)