diff options
| author | Christian Kolset <christian.kolset@gmail.com> | 2026-09-20 11:31:07 -0600 |
|---|---|---|
| committer | Christian Kolset <christian.kolset@gmail.com> | 2026-09-20 11:31:07 -0600 |
| commit | bb8be051ffffa56a01093c9f3aaa80e84748568f (patch) | |
| tree | db5c0e3e5f8a453984aea9c70afa007319c610c3 /ui/control_panel.py | |
| parent | f3327d56d48d63b21ffc03a55fa5e7db753d1707 (diff) | |
Fix Signal name reset and orphaned references on device reconfigure
Apply & Reconnect rebuilt a device's whole Signal list from hardware
defaults on every call, silently discarding user/profile-set names,
units, and colors even when pins hadn't changed. Add
merge_signal_metadata() and call it from ArduinoDevice.remap_pins()
and SerialDevice.reconfigure() to reapply the same fields
ProfileManager already treats as user overrides, keyed by signal_id.
Also close a related gap: removing a pin that a Channel/Plot/Control
still referenced left it silently dangling, and SignalProcessor never
pruned its latest-value cache, so a derived Channel kept computing off
a permanently frozen stale reading. Add SignalProcessor.
on_device_reconfigured() to purge that cache, reference_registry.
find_references() for a console breadcrumb, and live "missing source"
indicators on Plot traces and Channel blocks reusing ControlWidget's
existing stale/QSS pattern. Also fixes ControlWidget._write() still
enqueuing writes to a channel that no longer exists.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Diffstat (limited to 'ui/control_panel.py')
| -rw-r--r-- | ui/control_panel.py | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/ui/control_panel.py b/ui/control_panel.py index f008853..830b985 100644 --- a/ui/control_panel.py +++ b/ui/control_panel.py @@ -238,7 +238,10 @@ class ControlWidget(QFrame): dev = self.registry.get_instance(self.device_id) if dev: ch = dev.get_signal(self.channel_id) - if ch is not None and not ch.enabled: + if ch is None: + print(f"[Control] write_channel({self.channel_id}, {value}) skipped on " + f"{self.device_id} — channel no longer exists (removed by reconfigure)") + elif not ch.enabled: print(f"[Control] write_channel({self.channel_id}, {value}) skipped on " f"{self.device_id} — channel is disabled") elif dev.status not in (DeviceStatus.CONNECTED, DeviceStatus.SIMULATED): |