Merge branch 'feat/plugin-pip-install-prompt'

2 files changed, 60 insertions, 1 deletions

diff --git a/ui/main_window.py b/ui/main_window.py
index ca4274c..d585a83 100644
--- a/ui/main_window.py
+++ b/ui/main_window.py
@@ -303,11 +303,60 @@ class MainWindow(QMainWindow):
 
     def plugin_enable(self, plugin_id: str):
         """Called by SettingsWindow when user enables a plugin."""
+        missing = self._plugin_mgr.get_missing_dependencies(plugin_id)
+        if missing:
+            from PyQt6.QtWidgets import QMessageBox
+            reply = QMessageBox.question(
+                self, "Missing Plugin Dependencies",
+                f"This plugin needs packages that aren't installed:\n\n"
+                f"  {', '.join(missing)}\n\n"
+                f"Install them now with pip?",
+                QMessageBox.StandardButton.Yes | QMessageBox.StandardButton.No,
+                QMessageBox.StandardButton.No,
+            )
+            if reply == QMessageBox.StandardButton.Yes:
+                if self._pip_install(missing):
+                    self._enable_plugin_now(plugin_id)
+        else:
+            self._enable_plugin_now(plugin_id)
+        if self._win_settings:
+            self._win_settings.sync_plugin_button(plugin_id)
+
+    def _enable_plugin_now(self, plugin_id: str):
         ctx = self._make_plugin_context()
         plugin = self._plugin_mgr.enable(plugin_id, ctx)
         if plugin:
             self._install_plugin(plugin)
 
+    def _pip_install(self, requirements: list) -> bool:
+        """Blocking `pip install` of the given requirement strings.
+        Returns True on success; shows a result dialog either way."""
+        import subprocess
+        import sys
+        from PyQt6.QtWidgets import QMessageBox
+
+        QApplication.setOverrideCursor(Qt.CursorShape.WaitCursor)
+        try:
+            result = subprocess.run(
+                [sys.executable, "-m", "pip", "install", *requirements],
+                capture_output=True, text=True,
+            )
+        finally:
+            QApplication.restoreOverrideCursor()
+
+        if result.returncode == 0:
+            QMessageBox.information(
+                self, "Install Complete",
+                f"Installed: {', '.join(requirements)}"
+            )
+            return True
+        QMessageBox.critical(
+            self, "Install Failed",
+            f"pip install failed for: {', '.join(requirements)}\n\n"
+            f"{result.stderr.strip()[-1500:]}"
+        )
+        return False
+
     def plugin_disable(self, plugin_id: str):
         """Called by SettingsWindow when user disables a plugin."""
         self._uninstall_plugin(plugin_id)
diff --git a/ui/windows/settings_window.py b/ui/windows/settings_window.py
index e24da7f..290d9e0 100644
--- a/ui/windows/settings_window.py
+++ b/ui/windows/settings_window.py
@@ -51,6 +51,7 @@ class SettingsWindow(QWidget):
         self.registry       = registry
         self.engine         = engine
         self._plugin_mgr    = plugin_manager
+        self._plugin_buttons: dict = {}   # plugin_id -> QPushButton
         self.cfg            = dict(self._defaults)
         if current:
             self.cfg.update(current)
@@ -243,6 +244,7 @@ class SettingsWindow(QWidget):
         toggle.clicked.connect(
             lambda _, pid=manifest.plugin_id, btn=toggle: self._toggle_plugin(pid, btn)
         )
+        self._plugin_buttons[manifest.plugin_id] = toggle
         hdr.addWidget(toggle)
         cl.addLayout(hdr)
 
@@ -271,8 +273,16 @@ class SettingsWindow(QWidget):
             self.plugin_disable_requested.emit(plugin_id)
             btn.setText("Enable")
         else:
+            # Don't flip to "Disable" yet — enabling can fail (missing
+            # dependencies, bad plugin code). main_window confirms the
+            # real outcome via sync_plugin_button() once enable() returns.
             self.plugin_enable_requested.emit(plugin_id)
-            btn.setText("Disable")
+
+    def sync_plugin_button(self, plugin_id: str):
+        """Refresh one plugin's toggle button to match its actual enabled state."""
+        btn = self._plugin_buttons.get(plugin_id)
+        if btn is not None and self._plugin_mgr is not None:
+            btn.setText("Disable" if self._plugin_mgr.is_enabled(plugin_id) else "Enable")
 
     # ── Actions ───────────────────────────────────────────────────────────